FIFE forums

Please login or register.

Login with username, password and session length
Advanced search  

News:

FIFE 0.4.0 has been released on 15th of January, 2017!

Author Topic: view_performance branch testing  (Read 5670 times)

prock

  • Developer
  • Full Member
  • *
  • Posts: 236
    • View Profile
view_performance branch testing
« on: December 04, 2009, 10:50:36 am »

Hi all,

As many of you already know Phoku has almost completed his work on the view_performance branch he has been working on.  I'd like to say thanks to Phoku for his efforts!!!  We are all very happy (and lucky) to have such a talented member on the FIFE team!

Down to business.   I started this thread so we can collect and discuss any bugs that you can identify in the view_performance branch.  Phoku has merged trunk back into this branch so it is up to date.  If you find any issues please post them here so Phoku and the rest of the FIFE team can try and resolve the bugs.

As soon as we can resolve any issues that arise we would like to merge the view_performance branch back into trunk so that all clients can start benefiting from the better performance we have been seeing in testing.
Logged

Nihathrael

  • Developer
  • Newbie
  • *
  • Posts: 7
    • View Profile
Re: view_performance branch testing
« Reply #1 on: December 04, 2009, 10:53:39 am »

Hi,
first the performance improvement is running pretty nicely on full zoom in(70fps=>170fps). Zoomed out there is no difference. There is a little glitch though:
http://img229.imageshack.us/img229/3937/200912041742451024x768s.png
This happens if i zoom full out and then back in. (rev 3107)

Keep up the great work!
Nihathrael
Logged

mvBarracuda

  • Administrator
  • Sr. Member
  • *
  • Posts: 411
    • View Profile
Re: view_performance branch testing
« Reply #2 on: December 09, 2009, 07:42:46 am »

Feedback from the PARPG forums:
Quote from: amo-ej1
When I run the large map on fife trunk I get 20-30 fps, with the changes in trunk I get about 200 fps (but then again we might wish to add the possibility to render the fps string inside the hud somewhere for  more easy reference. (This is in 1024x768, not fullscreen)

The only remark I have is that now I see some artifacts (apar from the PC and NPC's starting to dans at the same locatio), these artifacts are not obviously reproducible and not screenshotable :( so you may either believe me or think that i was drunk while seeing them.

What I see is the following ,when the PC is moving, i think mainly when starting or ending a movement i sometimes see black lines which oultine a horizontal/vertical/diagonal cut through the scene but still following the tile outlines. This occurs about once a minute, but i haven't found a real way to trigger this ... i don't believe I ever saw this on the trunk (not in the past, not on trunk (of parpg and fife)).
Logged

flutschfinger

  • Newbie
  • Posts: 14
    • View Profile
Re: view_performance branch testing
« Reply #3 on: December 11, 2009, 11:22:50 am »

Hi,

by using this branch i got the following segment fault mostly every time i want to build a building.

Code: [Select]
./debug.py gdb --args python ./run_uh.py --fife-path=/home/kilian/Unknown_Horizons/FIFE/view_performance/
Executing with proper fife path: "gdb" with args ['gdb', '--args', 'python', './run_uh.py', '--fife-path=/home/kilian/Unknown_Horizons/FIFE/view_performance/']
GNU gdb (GDB) 7.0-ubuntu
Copyright (C) 2009 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-linux-gnu".
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>...
Reading symbols from /usr/bin/python...(no debugging symbols found)...done.
(gdb) run
The program being debugged has been started already.
Start it from the beginning? (y or n) y

Starting program: /usr/bin/python ./run_uh.py --fife-path=/home/kilian/Unknown_Horizons/FIFE/view_performance/
[Thread debugging using libthread_db enabled]
[New Thread 0x7fffed7d6910 (LWP 5004)]
[Thread 0x7fffed7d6910 (LWP 5004) exited]
[New Thread 0x7fffed7d6910 (LWP 5005)]
[New Thread 0x7fffe65f8910 (LWP 5006)]
[New Thread 0x7fffe5df7910 (LWP 5007)]
[New Thread 0x7fffe4c58910 (LWP 5008)]
[Thread 0x7fffe4c58910 (LWP 5008) exited]

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff37d377b in std::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string(std::string const&) () from /usr/lib/libstdc++.so.6
(gdb) bt
#0  0x00007ffff37d377b in std::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string(std::string const&) ()
   from /usr/lib/libstdc++.so.6
#1  0x00007ffff628aee9 in _wrap_Instance_getId (args=0x6c529d0)
    at engine/swigwrappers/python/fife_wrap.cxx:61076
#2  0x00000000004a2299 in PyEval_EvalFrameEx ()
#3  0x00000000004a40e0 in PyEval_EvalCodeEx ()
#4  0x00000000004a245f in PyEval_EvalFrameEx ()
#5  0x00000000004a40e0 in PyEval_EvalCodeEx ()
#6  0x000000000052be30 in ?? ()
#7  0x000000000041d6e7 in PyObject_Call ()
#8  0x00000000004254ff in ?? ()
#9  0x000000000041ec29 in ?? ()
#10 0x00000000004227b3 in PyObject_CallMethod ()
#11 0x00007ffff61b9ace in SwigDirector_IMouseListener::mousePressed (
    this=0x8c13a00, evt=...) at engine/swigwrappers/python/fife_wrap.cxx:6641
#12 0x00007ffff61a8181 in FIFE::EventManager::dispatchMouseEvent (
    this=0x10e9530, evt=...) at engine/core/eventchannel/eventmanager.cpp:211
#13 0x00007ffff61a8c53 in FIFE::EventManager::processMouseEvent (
    this=0x10e9530, event=...) at engine/core/eventchannel/eventmanager.cpp:406
#14 0x00007ffff61a884e in FIFE::EventManager::processEvents (this=0x10e9530)
    at engine/core/eventchannel/eventmanager.cpp:327
#15 0x00007ffff60dc580 in FIFE::Engine::pump (this=0xd7ae90)
---Type <return> to continue, or q <return> to quit---
    at engine/core/controller/engine.cpp:302
#16 0x00007ffff61f21ef in _wrap_Engine_pump (args=0x6c457d0)
    at engine/swigwrappers/python/fife_wrap.cxx:22934
#17 0x00000000004a2299 in PyEval_EvalFrameEx ()
#18 0x00000000004a40e0 in PyEval_EvalCodeEx ()
#19 0x00000000004a245f in PyEval_EvalFrameEx ()
#20 0x00000000004a2e47 in PyEval_EvalFrameEx ()
#21 0x00000000004a2e47 in PyEval_EvalFrameEx ()
#22 0x00000000004a2e47 in PyEval_EvalFrameEx ()
#23 0x00000000004a2e47 in PyEval_EvalFrameEx ()
#24 0x00000000004a40e0 in PyEval_EvalCodeEx ()
#25 0x00000000004a41b2 in PyEval_EvalCode ()
#26 0x00000000004c33a0 in PyRun_FileExFlags ()
#27 0x00000000004c3564 in PyRun_SimpleFileExFlags ()
#28 0x0000000000418ab7 in Py_Main ()
#29 0x00007ffff6fd0abd in __libc_start_main () from /lib/libc.so.6
#30 0x0000000000417ca9 in _start ()
(gdb)
« Last Edit: December 11, 2009, 11:24:31 am by kili »
Logged

prock

  • Developer
  • Full Member
  • *
  • Posts: 236
    • View Profile
Re: view_performance branch testing
« Reply #4 on: December 11, 2009, 06:36:16 pm »

Hi,

by using this branch i got the following segment fault mostly every time i want to build a building.

Can anyone else at UH reproduce this?
Logged

helios

  • Developer
  • Jr. Member
  • *
  • Posts: 61
    • View Profile
Re: view_performance branch testing
« Reply #5 on: December 20, 2009, 12:22:16 pm »

I tested the branch with Zero on fullscreen. (but not with the actual fife rev. because I ran into .png loader problem)
On worldmap is no difference but localmap speed up (360fps-->600fps).

Quote
The only remark I have is that now I see some artifacts (apar from the PC and NPC's starting to dans at the same locatio), these artifacts are not obviously reproducible and not screenshotable Sad so you may either believe me or think that i was drunk while seeing them.
Zero have the same problem.

Logged

phoku

  • Developer
  • Full Member
  • *
  • Posts: 102
    • View Profile
    • IZ dev blog
Re: view_performance branch testing
« Reply #6 on: December 29, 2009, 01:40:00 am »

I just wanted to say: Thanks for the thorough testing and kind words.  :)

I am aware of those glitches which aren't screenshotable,
and have a good idea where the segfault is coming from.

Hopefully I'll be able to work out those problems so that we may enjoy
a faster 3.0 release.

phoku
Logged

mvBarracuda

  • Administrator
  • Sr. Member
  • *
  • Posts: 411
    • View Profile
Re: view_performance branch testing
« Reply #7 on: December 29, 2009, 01:54:25 am »

Sounds great phoku :-) Keep up the good work!
Logged