FIFE forums

Please login or register.

Login with username, password and session length
Advanced search  

News:

FIFE 0.4.0 has been released on 15th of January, 2017!

Author Topic: Togglebutton patch  (Read 2366 times)

CheeseSucker

  • Developer
  • Newbie
  • *
  • Posts: 26
  • FIFE programmer
    • View Profile
Togglebutton patch
« on: January 11, 2009, 08:39:39 pm »

In the process of getting know FIFE (again) I made a few changes to pychan and the editor and made a ToggleButton. This button can be toggled, and would therefore fit better in the Toolbox than regular pushbuttons. By setting the group parameter, only one button in the group can be toggled at one time.

I talked with spq, and he advised me to split the code from TwoButton/ImageButton and into a new class. Unfortunately, this resulted in some code duplication, but that might be fixed later. The code lacks some comments and documentation, but I would like to know what you think about it before I do anything more.

I'm sorry for any poor explanations I give here, but I'm quite tired and would like to go to bed ;-)

I've attached a patch made with TortoiseSVN.

Edit: Nihathrael experienced some problems with the attached patch. Try instead: http://fife.pastebin.com/m5af7bb6
« Last Edit: January 12, 2009, 03:45:29 pm by CheeseSucker »
Logged

LinuxDonald

  • Newbie
  • Posts: 28
    • View Profile
    • My Blog (German)
Re: Togglebutton patch
« Reply #1 on: January 23, 2009, 07:49:09 pm »

Give it any news about the status of this patch?
Logged

CheeseSucker

  • Developer
  • Newbie
  • *
  • Posts: 26
  • FIFE programmer
    • View Profile
Re: Togglebutton patch
« Reply #2 on: January 25, 2009, 12:24:07 pm »

I've been busy in the last week, so I haven't gotten much done.

Before the togglebutton can be commited to SVN, I need to finish some changes I made to the togglebutton and document and clean up the code.

I'll try to get it done this evening.
Logged